chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc - Issue 2121203002: Add BrowsingDataCounterFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc

Issue 2121203002: Add BrowsingDataCounterFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_bd_counters_to_components

Patch Set: Fixed Android code and rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_counter_factory.h » ('j') | chrome/browser/browsing_data/browsing_data_counter_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc

diff --git a/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc b/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc

index 3af31e0dc04f4f1d4712fc155ad2252867e89e91..357dc2561d3a1b7d8029d628cf2b62ba04f6f54f 100644

--- a/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc

+++ b/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/android/browsing_data/browsing_data_counter_bridge.h"

#include "base/android/jni_string.h"

+#include "chrome/browser/browsing_data/browsing_data_counter_factory.h"

#include "chrome/browser/browsing_data/browsing_data_counter_utils.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

@@ -26,7 +27,7 @@ BrowsingDataCounterBridge::BrowsingDataCounterBridge(

Profile* profile =

ProfileManager::GetActiveUserProfile()->GetOriginalProfile();

- counter_.reset(CreateCounterForPreference(pref, profile));

msramek 2016/07/07 11:55:32 Why don't we remove this method?

ioanap 2016/07/07 16:30:48 Oups! Removed it now.

+ counter_.reset(BrowsingDataCounterFactory::GetForPreference(pref, profile));

if (!counter_)

return;

« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_counter_factory.h » ('j') | chrome/browser/browsing_data/browsing_data_counter_factory.h » ('J')