chrome/browser/browsing_data/browsing_data_counter_utils.cc - Issue 2121203002: Add BrowsingDataCounterFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_counter_utils.cc

Issue 2121203002: Add BrowsingDataCounterFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_bd_counters_to_components

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_counter_utils.h ('k') | chrome/browser/ui/webui/options/clear_browser_data_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_counter_utils.cc

diff --git a/chrome/browser/browsing_data/browsing_data_counter_utils.cc b/chrome/browser/browsing_data/browsing_data_counter_utils.cc

index 16354972102eb65d5fc6b7fc7b7076c33a50002e..9e855e60893fabe4fc7ad0029c5ee751ba9ef04a 100644

--- a/chrome/browser/browsing_data/browsing_data_counter_utils.cc

+++ b/chrome/browser/browsing_data/browsing_data_counter_utils.cc

@@ -261,21 +261,3 @@ bool GetDeletionPreferenceFromDataType(

NOTREACHED();

return false;

}

-browsing_data::BrowsingDataCounter* CreateCounterForPreference(

- std::string pref_name,

- Profile* profile) {

- if (!AreCountersEnabled())

- return nullptr;

- if (pref_name == prefs::kDeleteBrowsingHistory)

- return new HistoryCounter(profile);

- if (pref_name == prefs::kDeleteCache)

- return new CacheCounter(profile);

- if (pref_name == prefs::kDeletePasswords)

- return new PasswordsCounter(profile);

- if (pref_name == prefs::kDeleteFormData)

- return new AutofillCounter(profile);

- return nullptr;