third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h - Issue 2121173002: [css-grid] Fix percentage height resolution for replaced elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2121173002: [css-grid] Fix percentage height resolution for replaced elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

index f61090f4c32613bfdc8f7f456ef4c972f8f8a64e..970ba9255395bc29420a1b99c817028270dc17d4 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

@@ -325,7 +325,7 @@ protected:

LayoutRect localCaretRectForEmptyElement(LayoutUnit width, LayoutUnit textIndentOffset);

- bool hasAutoHeightOrContainingBlockWithAutoHeight() const;

+ bool hasAutoHeightOrContainingBlockWithAutoHeight(bool checkingContainingBlock = false) const;

LayoutBlock* containingBlockForAutoHeightDetection(Length logicalHeight) const;

void addOutlineRectsForNormalChildren(Vector<LayoutRect>&, const LayoutPoint& additionalOffset, IncludeBlockVisualOverflowOrNot) const;