Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2121153003: [turbofan] Remove eager frame state from divisions. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from divisions. This removes the frame state input representing the before-state from nodes having the {JSDivide} or the {JSModulus} operator. Lowering that inserts number conversions of the inputs has to be disabled when deoptimization is enabled, because the frame state layout is no longer known. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/b1cbb9838756bbdfcb631d9c8adfb673942eb987 Cr-Commit-Position: refs/heads/master@{#37608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M src/compiler/js-typed-lowering.cc View 3 chunks +24 lines, -19 lines 0 comments Download
M src/compiler/operator-properties.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-05 13:28:52 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-08 09:36:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121153003/1
4 years, 5 months ago (2016-07-08 09:53:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19076)
4 years, 5 months ago (2016-07-08 09:59:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121153003/1
4 years, 5 months ago (2016-07-08 11:16:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 11:18:36 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 11:18:37 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 11:20:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1cbb9838756bbdfcb631d9c8adfb673942eb987
Cr-Commit-Position: refs/heads/master@{#37608}

Powered by Google App Engine
This is Rietveld 408576698