Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2121143003: DebugVisualizers: Add HashTable and Font-related classes (Closed)

Created:
4 years, 5 months ago by kojii
Modified:
4 years, 5 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DebugVisualizers: Add HashTable and Font-related classes This patch adds DebugVisuzalizers for: - WTF:HashTable - blink::Font - blink::FontFamily Committed: https://crrev.com/3bb567c1a5d2b71ff5ef9123f70f6693ee8d34fb Cr-Commit-Position: refs/heads/master@{#404769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M tools/win/DebugVisualizers/webkit.natvis View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kojii
PTAL+CQ.
4 years, 5 months ago (2016-07-06 05:07:05 UTC) #3
brucedawson
lgtm
4 years, 5 months ago (2016-07-11 20:37:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121143003/1
4 years, 5 months ago (2016-07-12 01:19:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 02:52:38 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 02:52:53 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 02:53:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bb567c1a5d2b71ff5ef9123f70f6693ee8d34fb
Cr-Commit-Position: refs/heads/master@{#404769}

Powered by Google App Engine
This is Rietveld 408576698