Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2121143002: Update tests to make latent errors explicit. (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M tests/language/compile_time_constant_e_test.dart View 1 chunk +0 lines, -1 line 1 comment Download
M tests/language/language_dart2js.status View 2 chunks +2 lines, -2 lines 2 comments Download
M tests/language/regress_22976_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/language/setter4_test.dart View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/2121143002/diff/1/tests/language/compile_time_constant_e_test.dart File tests/language/compile_time_constant_e_test.dart (left): https://codereview.chromium.org/2121143002/diff/1/tests/language/compile_time_constant_e_test.dart#oldcode22 tests/language/compile_time_constant_e_test.dart:22: const a1n = const A.n(99, 100); Unused in test.
4 years, 5 months ago (2016-07-05 10:34:16 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2121143002/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/2121143002/diff/1/tests/language/language_dart2js.status#newcode8 tests/language/language_dart2js.status:8: setter4_test: CompileTimeError # issue 13669 I don't think ...
4 years, 5 months ago (2016-07-06 16:15:12 UTC) #3
Johnni Winther
https://codereview.chromium.org/2121143002/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/2121143002/diff/1/tests/language/language_dart2js.status#newcode8 tests/language/language_dart2js.status:8: setter4_test: CompileTimeError # issue 13669 On 2016/07/06 16:15:12, Harry ...
4 years, 5 months ago (2016-07-08 08:23:53 UTC) #4
Johnni Winther
4 years, 5 months ago (2016-07-08 08:41:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5f243e6bd0367765296fa34af8f9b0d583be952c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698