Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2121123002: Broaden the condition under which gold is used as linker. (Closed)

Created:
4 years, 5 months ago by Stefano Sanfilippo
Modified:
4 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Achenbach, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Broaden the condition under which gold is used as linker. LOG=N Committed: https://crrev.com/8465244e79b587aecf7d7c7ab7f89148530b9a7c Cr-Commit-Position: refs/heads/master@{#37521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gypfiles/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gypfiles/toolchain.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Stefano Sanfilippo
PTAL.
4 years, 5 months ago (2016-07-05 09:59:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121123002/1
4 years, 5 months ago (2016-07-05 09:59:37 UTC) #4
Michael Achenbach
lgtm
4 years, 5 months ago (2016-07-05 10:00:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-05 10:23:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121123002/1
4 years, 5 months ago (2016-07-05 10:23:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 10:25:30 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 10:25:33 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 10:28:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8465244e79b587aecf7d7c7ab7f89148530b9a7c
Cr-Commit-Position: refs/heads/master@{#37521}

Powered by Google App Engine
This is Rietveld 408576698