Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2121103002: PlzNavigate: Triage tests that are failing due to crbug.com/625765 (Closed)

Created:
4 years, 5 months ago by blundell
Modified:
4 years, 5 months ago
Reviewers:
clamy
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Triage tests that are failing due to crbug.com/625765 These tests were found by a couple of hacky and incomplete renderer-side fixes to the problem. BUG=625765 Committed: https://crrev.com/5a4fe32fc2b28a61e33f0cad0a7167a7ab88e80d Cr-Commit-Position: refs/heads/master@{#404152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 5 chunks +18 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
blundell
4 years, 5 months ago (2016-07-05 08:43:41 UTC) #2
clamy
Thanks! Lgtm.
4 years, 5 months ago (2016-07-07 12:22:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121103002/1
4 years, 5 months ago (2016-07-07 12:23:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 13:58:00 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 13:58:05 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 13:59:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a4fe32fc2b28a61e33f0cad0a7167a7ab88e80d
Cr-Commit-Position: refs/heads/master@{#404152}

Powered by Google App Engine
This is Rietveld 408576698