ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm - Issue 2121083004: Upstream ProfileOAuth2TokenServiceProviderImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm

Issue 2121083004: Upstream ProfileOAuth2TokenServiceProviderImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm

diff --git a/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm b/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm

index 2ff9a2fd8b44a56f89415a25fd7b4f8a31991325..66b942ff976fe4e43c56ed5fbf51734f10ada661 100644

--- a/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm

+++ b/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm

@@ -7,11 +7,11 @@

#include "base/memory/ptr_util.h"

#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"

#include "components/signin/ios/browser/fake_profile_oauth2_token_service_ios_delegate.h"

+#include "components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.h"

#include "ios/chrome/browser/browser_state/chrome_browser_state.h"

#include "ios/chrome/browser/signin/account_tracker_service_factory.h"

#include "ios/chrome/browser/signin/signin_client_factory.h"

#include "ios/chrome/browser/signin/signin_error_controller_factory.h"

-#include "ios/public/provider/chrome/browser/chrome_browser_provider.h"

std::unique_ptr<KeyedService> BuildFakeOAuth2TokenService(

web::BrowserState* context) {

@@ -20,8 +20,7 @@ std::unique_ptr<KeyedService> BuildFakeOAuth2TokenService(

OAuth2TokenServiceDelegate* delegate =

new FakeProfileOAuth2TokenServiceIOSDelegate(

SigninClientFactory::GetForBrowserState(browser_state),

- ios::GetChromeBrowserProvider()

- ->GetProfileOAuth2TokenServiceIOSProvider(),

+ base::WrapUnique(new FakeProfileOAuth2TokenServiceIOSProvider()),

sdefresne 2016/07/06 08:43:28 It is better to use base::MakeUnique here: base::

bzanotti 2016/07/06 11:02:21 Done.

ios::AccountTrackerServiceFactory::GetForBrowserState(browser_state),

ios::SigninErrorControllerFactory::GetForBrowserState(browser_state));

return base::WrapUnique(new FakeProfileOAuth2TokenService(delegate));