Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2121083004: Upstream ProfileOAuth2TokenServiceProviderImpl. (Closed)

Created:
4 years, 5 months ago by bzanotti
Modified:
4 years, 5 months ago
Reviewers:
sdefresne, msarda
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream ProfileOAuth2TokenServiceProviderImpl. BUG=625864 Committed: https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6 Cr-Commit-Position: refs/heads/master@{#403920}

Patch Set 1 #

Patch Set 2 : Better comments #

Patch Set 3 : Remove ProfileOAuth2TokenServiceProvider from ChromeBrowserProvider #

Patch Set 4 : Clean up #

Patch Set 5 : Fix compilation #

Total comments: 12

Patch Set 6 : Style nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -59 lines) Patch
M components/signin/ios/browser/fake_profile_oauth2_token_service_ios_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/signin/ios/browser/fake_profile_oauth2_token_service_ios_delegate.mm View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios_delegate_unittest.mm View 1 2 3 4 12 chunks +23 lines, -21 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/signin/oauth2_token_service_factory.mm View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
A ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.h View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm View 1 2 3 4 5 1 chunk +109 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/signin_error_provider.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/signin_error_provider.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.mm View 1 2 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
bzanotti
Please take a look.
4 years, 5 months ago (2016-07-05 17:07:23 UTC) #2
bzanotti
Sylvain: Please do an OWNERS review on the ChromeBrowserProvider files.
4 years, 5 months ago (2016-07-05 17:47:18 UTC) #4
msarda
lgtm
4 years, 5 months ago (2016-07-06 08:05:51 UTC) #7
sdefresne
lgtm with comments https://codereview.chromium.org/2121083004/diff/110001/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm File ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm (right): https://codereview.chromium.org/2121083004/diff/110001/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm#newcode23 ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm:23: base::WrapUnique(new FakeProfileOAuth2TokenServiceIOSProvider()), It is better to ...
4 years, 5 months ago (2016-07-06 08:43:29 UTC) #8
bzanotti
https://codereview.chromium.org/2121083004/diff/110001/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm File ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm (right): https://codereview.chromium.org/2121083004/diff/110001/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm#newcode23 ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm:23: base::WrapUnique(new FakeProfileOAuth2TokenServiceIOSProvider()), On 2016/07/06 08:43:28, sdefresne wrote: > It ...
4 years, 5 months ago (2016-07-06 11:02:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121083004/130001
4 years, 5 months ago (2016-07-06 11:02:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121083004/130001
4 years, 5 months ago (2016-07-06 16:58:03 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:130001)
4 years, 5 months ago (2016-07-06 17:03:26 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 17:03:39 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 17:04:40 UTC) #19
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6
Cr-Commit-Position: refs/heads/master@{#403920}

Powered by Google App Engine
This is Rietveld 408576698