Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2121083003: Version 5.3.332.7 (cherry-pick) (Closed)

Created:
4 years, 5 months ago by nickie
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.3
Target Ref:
refs/pending/branch-heads/5.3
Project:
v8
Visibility:
Public.

Description

Version 5.3.332.7 (cherry-pick) Merged 61c137c8116a800d179ada40570d62a0b70f1d2d Fix bug with re-scoping arrow function parameter initializers BUG=chromium:622663 LOG=N R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopes.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/ast/scopes.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/parsing/parameter-initializer-rewriter.cc View 4 chunks +12 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-622663.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nickie
4 years, 5 months ago (2016-07-05 13:41:19 UTC) #1
Michael Hablich
On 2016/07/05 13:41:19, nickie wrote: Lgtm
4 years, 5 months ago (2016-07-05 14:14:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121083003/1
4 years, 5 months ago (2016-07-05 14:31:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 14:31:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698