Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2121083002: Add UseCounters for BeforeInstallPromptEvent. (Closed)

Created:
4 years, 5 months ago by dominickn
Modified:
4 years, 5 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, dominickn+watch_chromium.org, haraken, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounters for BeforeInstallPromptEvent. These stats will help identify how often developers catch the event and call its methods. BUG=625716 Committed: https://crrev.com/cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48 Cr-Commit-Position: refs/heads/master@{#404430}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp View 5 chunks +16 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
dominickn
PTAL, thanks! I haven't implemented one of these UseCounters before so I hope this is ...
4 years, 5 months ago (2016-07-05 07:54:56 UTC) #2
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-07-06 23:03:40 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 5 months ago (2016-07-07 10:20:30 UTC) #4
dstockwell
lgtm
4 years, 5 months ago (2016-07-08 01:42:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121083002/20001
4 years, 5 months ago (2016-07-08 01:45:43 UTC) #9
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-07-08 14:27:29 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:27:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121083002/40001
4 years, 5 months ago (2016-07-08 14:40:17 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 17:39:04 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 17:39:21 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 17:41:32 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48
Cr-Commit-Position: refs/heads/master@{#404430}

Powered by Google App Engine
This is Rietveld 408576698