Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2121073002:
Add a helper function for allocating XPointer ranges. (Closed)
|
Created:
4 years, 5 months ago by dominicc (has gone to gerrit) Modified:
4 years, 4 months ago Reviewers:
inferno CC:
dominicc+watchlist_chromium.org, scottmg Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a helper function for allocating XPointer ranges.
BUG=624011
Committed: https://crrev.com/6eee7eee18990d52a5e0723058f0e4d186e1e278
Cr-Commit-Position: refs/heads/master@{#408330}
Patch Set 1 #Patch Set 2 : Rebase. #
Messages
Total messages: 23 (13 generated)
dominicc@chromium.org changed reviewers: + scottmg@chromium.org
PTAL
dominicc@chromium.org changed reviewers: + dominickn@chromium.org, inferno@chromium.org - scottmg@chromium.org
PTAL; scottmg is OOF.
On 2016/07/13 07:09:30, dominicc wrote: > PTAL; scottmg is OOF. Given that this patch is more complex than the previous one, I am not familiar enough to give it a confident lg. Deferring to inferno. :)
dominicc@chromium.org changed reviewers: - dominickn@chromium.org
Ping inferno, PTAL. Bots are red because the issue is protected, I think.
Description was changed from ========== Add a helper function for allocating XPointer ranges. BUG=624011 ========== to ========== Add a helper function for allocating XPointer ranges. BUG=624011 ==========
lgtm. No need to keep issue protected. Removed that bit, cq should run fine now.
The CQ bit was checked by dominicc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by dominicc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dominicc@chromium.org
The CQ bit was checked by dominicc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from inferno@chromium.org Link to the patchset: https://codereview.chromium.org/2121073002/#ps20001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a helper function for allocating XPointer ranges. BUG=624011 ========== to ========== Add a helper function for allocating XPointer ranges. BUG=624011 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add a helper function for allocating XPointer ranges. BUG=624011 ========== to ========== Add a helper function for allocating XPointer ranges. BUG=624011 Committed: https://crrev.com/6eee7eee18990d52a5e0723058f0e4d186e1e278 Cr-Commit-Position: refs/heads/master@{#408330} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6eee7eee18990d52a5e0723058f0e4d186e1e278 Cr-Commit-Position: refs/heads/master@{#408330} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
