Have PlatformScreen use DisplayConfigurator.

Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from services/ui. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876
Committed: https://crrev.com/0b41be7853346d302ffece00f31bd12112dbfa4a
Cr-Commit-Position: refs/heads/master@{#404151}

[kylechar, 2016-07-05 18:31:30]

Description was changed from

==========
Have PlatformScreen use DisplayConfigurator.

On Chrome OS have PlatformScreen use DisplayConfigurator to configure
displays. It will trigger the default configuration using the native
display resolution.

BUG=TBD
==========

to

==========
Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from ui/services. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876
==========

[kylechar, 2016-07-05 18:32:50]

kylechar@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-07-06 18:18:36]

lgtm with nits, but I don't know this area too well.

https://codereview.chromium.org/2121053002/diff/1/services/ui/ws/platform_scr...
File services/ui/ws/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/2121053002/diff/1/services/ui/ws/platform_scr...
services/ui/ws/platform_screen_impl_ozone.cc:74: gfx::Point origin(0, 0);
nit: use default dtor

https://codereview.chromium.org/2121053002/diff/1/services/ui/ws/platform_scr...
services/ui/ws/platform_screen_impl_ozone.cc:81: // Move origin so that next
display is to right of current display.
nit: 'the origin', 'to the right' or 'is right', and 'the current'.

[kylechar, 2016-07-06 18:43:22]

Thanks. I added back the unnecessary looking #ifdef. Turns out it was necessary,
so I added a comment to explain why.

https://codereview.chromium.org/2121053002/diff/1/services/ui/ws/platform_scr...
File services/ui/ws/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/2121053002/diff/1/services/ui/ws/platform_scr...
services/ui/ws/platform_screen_impl_ozone.cc:74: gfx::Point origin(0, 0);
On 2016/07/06 18:18:36, msw wrote:
> nit: use default dtor

Done.

https://codereview.chromium.org/2121053002/diff/1/services/ui/ws/platform_scr...
services/ui/ws/platform_screen_impl_ozone.cc:81: // Move origin so that next
display is to right of current display.
On 2016/07/06 18:18:36, msw wrote:
> nit: 'the origin', 'to the right' or 'is right', and 'the current'.

Done.

[kylechar, 2016-07-06 18:44:21]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-07-06 18:44:22]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2121053002/#ps20001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-07-06 18:45:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 19:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 19:03:07]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kylechar, 2016-07-06 19:55:34]

On 2016/07/06 19:03:07, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Hmm. I'm actually not sure why cast_shell_linux is compiling mus at all. We can
use PlatformScreenImpl when is_chromecast=true instead which will avoid a bunch
of ugly #ifdefs around all the chromeos specific code.

[kylechar, 2016-07-07 12:59:27]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-07-07 12:59:28]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2121053002/#ps60001
(title: "Fix cast for real.")

[commit-bot: I haz the power, 2016-07-07 12:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2016-07-07 13:30:20]

Description was changed from

==========
Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from ui/services. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876
==========

to

==========
Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from services/ui. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876
==========

[commit-bot: I haz the power, 2016-07-07 13:54:19]

Description was changed from

==========
Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from services/ui. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876
==========

to

==========
Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from services/ui. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876
==========

[commit-bot: I haz the power, 2016-07-07 13:54:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-07 13:54:25]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 13:56:01]

Description was changed from

==========
Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from services/ui. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876
==========

to

==========
Make PlatformScreenImplOzone use DisplayConfigurator.

Currently the PlatformScreen implementation for Ozone uses
NativeDisplayDelegate directly. DisplayConfigurator is already designed
to use it and is accessible from services/ui. Change the implementation
to use DisplayConfigurator instead.

This provides PlatformScreen with much of the necessary display
configuration code it will need for multiple monitor support. For now
PlatformScreenImplOzone just forces the native resolution on 1 display.

BUG=625876

Committed: https://crrev.com/0b41be7853346d302ffece00f31bd12112dbfa4a
Cr-Commit-Position: refs/heads/master@{#404151}
==========

[commit-bot: I haz the power, 2016-07-07 13:56:02]

Patchset 4 (id:??) landed as
https://crrev.com/0b41be7853346d302ffece00f31bd12112dbfa4a
Cr-Commit-Position: refs/heads/master@{#404151}