gpu/command_buffer/common/gles2_cmd_utils.cc - Issue 2121043002: 16 bpp video stream capture, render and WebGL usage - Realsense R200 & SR300 support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/common/gles2_cmd_utils.cc

Issue 2121043002: 16 bpp video stream capture, render and WebGL usage - Realsense R200 & SR300 support. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests: cc, skcanvas_video_renderer, wrtcrecorder... Fake capture supports Y16. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/output/renderer_pixeltest.cc ('K') | « gpu/command_buffer/client/gles2_implementation.cc ('k') | gpu/command_buffer/common/gpu_memory_buffer_support.cc » ('j') | gpu/command_buffer/service/feature_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/common/gles2_cmd_utils.cc

diff --git a/gpu/command_buffer/common/gles2_cmd_utils.cc b/gpu/command_buffer/common/gles2_cmd_utils.cc

index b68bb0b0ca830bef7b52ce73f69e077b980c0377..dba4b4f574133f8c174b48db7beb1d155506c968 100644

--- a/gpu/command_buffer/common/gles2_cmd_utils.cc

+++ b/gpu/command_buffer/common/gles2_cmd_utils.cc

@@ -1091,7 +1091,7 @@ uint32_t GLES2Util::GetGLReadPixelsImplementationType(uint32_t internal_format,

case GL_RGB32F:

case GL_RGBA32F:

case GL_R11F_G11F_B10F:

- return GL_UNSIGNED_BYTE;

+ return GL_FLOAT;

Ken Russell (switch to Gerrit) 2016/09/30 23:01:29 I think this change is actually wrong. For these f

aleksandar.stojiljkovic 2016/10/03 10:56:52 Done. Wasn't important. GL_IMPLEMENTATION_COLOR_RE

case GL_R16F:

case GL_RG16F:

case GL_RGB16F: