16 bpp video stream capture, render and WebGL usage - Realsense R200 & SR300 support.

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <vector>
@@ skipping 1263 matching lines @@
     validators_.texture_internal_format.AddValue(GL_RG8_EXT);
     validators_.read_pixel_format.AddValue(GL_RED_EXT);
     validators_.read_pixel_format.AddValue(GL_RG_EXT);
     validators_.render_buffer_format.AddValue(GL_R8_EXT);
     validators_.render_buffer_format.AddValue(GL_RG8_EXT);
     validators_.texture_unsized_internal_format.AddValue(GL_RED_EXT);
     validators_.texture_unsized_internal_format.AddValue(GL_RG_EXT);
   }
   UMA_HISTOGRAM_BOOLEAN("GPU.TextureRG", feature_flags_.ext_texture_rg);
 
+  if (enable_texture_storage && enable_texture_float &&
+      feature_flags_.ext_texture_rg) {
+    validators_.texture_internal_format.AddValue(GL_R32F_EXT);
+  }
+
+  if (enable_texture_storage && enable_texture_half_float &&
+      feature_flags_.ext_texture_rg) {
+    validators_.texture_internal_format.AddValue(GL_R16F_EXT);
+  }

[Ken Russell (switch to Gerrit), 2016/09/30 23:01:29]

Instead of adding these values in separate if-statements, could you move the
block above (regarding  feature_flags_.ext_texture_rg) above the block higher
starting with "if (enable_texture_storage)"?

That way these could just be folded into the existing tests during the enabling
of the texture_storage extension (where they ostensibly belong).

[aleksandar.stojiljkovic, 2016/10/03 10:56:52]

tOn 2016/09/30 23:01:29, Ken Russell wrote:
Done. For future reference (if submitting patch related to this), the code is
wrong - texture_internal_format_storage validator should be modified, not
texture_internal_format.

+
   bool has_opengl_dual_source_blending =
       gl_version_info_->IsAtLeastGL(3, 3) ||
       (gl_version_info_->IsAtLeastGL(3, 2) &&
        extensions.Contains("GL_ARB_blend_func_extended"));
   if (!disable_shader_translator_ &&
       ((gl_version_info_->IsAtLeastGL(3, 2) &&
         has_opengl_dual_source_blending) ||
        (gl_version_info_->IsAtLeastGLES(3, 0) &&
         extensions.Contains("GL_EXT_blend_func_extended")))) {
     // Note: to simplify the code, we do not expose EXT_blend_func_extended
@@ skipping 169 matching lines @@
   if (pos == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu