Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 212103013: Add channel_count parameter back to AudioBuffer creation methods. (Closed)

Created:
6 years, 9 months ago by rileya (GONE FROM CHROMIUM)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mstr
Visibility:
Public.

Description

Add channel_count parameter back to AudioBuffer creation methods. This fixes a bug where we failed to set the proper channel count on AudioBuffers with the CHANNEL_LAYOUT_DISCRETE channel layout. BUG=357801 R=dalecurtis@chromium.org TBR=dmichael Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260333

Patch Set 1 #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -70 lines) Patch
M content/renderer/pepper/content_decryptor_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/audio_buffer.h View 3 chunks +4 lines, -0 lines 0 comments Download
M media/base/audio_buffer.cc View 9 chunks +12 lines, -1 line 0 comments Download
M media/base/audio_buffer_converter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/audio_buffer_converter_unittest.cc View 1 6 chunks +67 lines, -29 lines 0 comments Download
M media/base/audio_buffer_queue_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M media/base/audio_buffer_unittest.cc View 11 chunks +20 lines, -9 lines 0 comments Download
M media/base/audio_splicer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/audio_splicer_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/test_helpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/test_helpers.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/filters/audio_renderer_algorithm_unittest.cc View 3 chunks +32 lines, -25 lines 0 comments Download
M media/filters/audio_renderer_impl_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/opus_audio_decoder.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rileya (GONE FROM CHROMIUM)
Should fix the Mac crashes. PTAL.
6 years, 9 months ago (2014-03-28 22:55:27 UTC) #1
rileya (GONE FROM CHROMIUM)
+dmichael for OWNER review of content/renderer/pepper/content_decryptor_delegate.cc
6 years, 9 months ago (2014-03-28 22:56:27 UTC) #2
DaleCurtis
lgtm
6 years, 9 months ago (2014-03-28 23:07:01 UTC) #3
scherkus (not reviewing)
FYI you can usually TBR OWNERS of files affected by trivial API changes that the ...
6 years, 9 months ago (2014-03-28 23:16:56 UTC) #4
rileya (GONE FROM CHROMIUM)
Good point, TBR-ing dmichael.
6 years, 9 months ago (2014-03-28 23:21:30 UTC) #5
rileya (GONE FROM CHROMIUM)
The CQ bit was checked by rileya@chromium.org
6 years, 9 months ago (2014-03-28 23:21:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/212103013/20001
6 years, 9 months ago (2014-03-28 23:23:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 01:03:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 01:03:39 UTC) #9
rileya (GONE FROM CHROMIUM)
The CQ bit was checked by rileya@chromium.org
6 years, 9 months ago (2014-03-29 01:07:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/212103013/20001
6 years, 9 months ago (2014-03-29 01:08:14 UTC) #11
DaleCurtis
Committed patchset #2 manually as r260333 (presubmit successful).
6 years, 9 months ago (2014-03-29 01:33:03 UTC) #12
dmichael(do not use this one)
6 years, 8 months ago (2014-03-31 17:46:04 UTC) #13
Message was sent while issue was closed.
(late pepper lgtm)

Powered by Google App Engine
This is Rietveld 408576698