Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2120983002:
gpu, cmaa: don't blend the leftmost and bottom-most edges in the BLUR_EDGES path. (Closed)
Descriptiongpu, cmaa: don't blend the left/right/top/bottom-most edges in the BLUR_EDGES path.
textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height))
gives an undefined value. BLUR_EDGES pass can fetche (-1,_), (_,-1), (w,_), (_,h) texel,
which is an undefiend value. So BLUR_EDGES can mislead the left most
edge is dominant edge after comparing the undefined value and the left most
pixel.
This CL fixes parts of 2 WebGL conformance tests
https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html
https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/copy-tex-image-and-sub-image-2d.html
BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/58b7cc33f7817c8aeae707e1a440e4b170ad1f65
Cr-Commit-Position: refs/heads/master@{#403773}
Patch Set 1 #Patch Set 2 : handle rightmost and topmost edges also #Messages
Total messages: 21 (12 generated)
Description was changed from ========== gpu, cmaa: don't blend the leftmost and bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass fetches (-1 , _) or (_, -1) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" ========== to ========== gpu, cmaa: don't blend the leftmost and bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass fetches (-1 , _) or (_, -1) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + adrian.belgun@intel.com, jon.kennedy@intel.com, zmo@chromium.org
jon, adrian, could you review? zmo@, could you review as owner? It's one of two patches to fix the two webgl tests. https://bugs.chromium.org/p/chromium/issues/detail?id=535198#c30
Description was changed from ========== gpu, cmaa: don't blend the leftmost and bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass fetches (-1 , _) or (_, -1) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: don't blend the leftmost and bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass fetches (-1 , _) or (_, -1) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + piman@chromium.org
lgtm
owner stamp lgtm
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dongseong.hwang@intel.com
Description was changed from ========== gpu, cmaa: don't blend the leftmost and bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass fetches (-1 , _) or (_, -1) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: don't blend the left/right/top/bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass can fetche (-1,_), (_,-1), (w,_), (_,h) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CL is updated. Could you review again? With the previous patch, following test is occationally failed. (~1 over 20 times) https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... New patch fixes the flakiness.
Patchset #2 (id:20001) has been deleted
On 2016/07/05 11:25:15, dshwang wrote: > The CL is updated. Could you review again? > > With the previous patch, following test is occationally failed. (~1 over 20 > times) > https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... > > New patch fixes the flakiness. lgtm
The CQ bit was checked by dongseong.hwang@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org, adrian.belgun@intel.com Link to the patchset: https://codereview.chromium.org/2120983002/#ps40001 (title: "handle rightmost and topmost edges also")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: don't blend the left/right/top/bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass can fetche (-1,_), (_,-1), (w,_), (_,h) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: don't blend the left/right/top/bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass can fetche (-1,_), (_,-1), (w,_), (_,h) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: don't blend the left/right/top/bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass can fetche (-1,_), (_,-1), (w,_), (_,h) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: don't blend the left/right/top/bottom-most edges in the BLUR_EDGES path. textureGatherOffset() on out of range (i.e. outside of x = [0, width) or y = [0, height)) gives an undefined value. BLUR_EDGES pass can fetche (-1,_), (_,-1), (w,_), (_,h) texel, which is an undefiend value. So BLUR_EDGES can mislead the left most edge is dominant edge after comparing the undefined value and the left most pixel. This CL fixes parts of 2 WebGL conformance tests https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-... https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co... BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/58b7cc33f7817c8aeae707e1a440e4b170ad1f65 Cr-Commit-Position: refs/heads/master@{#403773} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/58b7cc33f7817c8aeae707e1a440e4b170ad1f65 Cr-Commit-Position: refs/heads/master@{#403773} |
