Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2120963002: [fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a keyed store to a... (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/ppc/full-codegen-ppc.cc
diff --git a/src/full-codegen/ppc/full-codegen-ppc.cc b/src/full-codegen/ppc/full-codegen-ppc.cc
index 7201c19ab378d3614e3120a1eeeb4575b994e57b..f6a7197dc8806b2ddd565751ef9ea03aec057a9e 100644
--- a/src/full-codegen/ppc/full-codegen-ppc.cc
+++ b/src/full-codegen/ppc/full-codegen-ppc.cc
@@ -1657,18 +1657,18 @@ void FullCodeGenerator::VisitAssignment(Assignment* expr) {
}
break;
case KEYED_SUPER_PROPERTY: {
- const Register scratch = r4;
VisitForStackValue(
property->obj()->AsSuperPropertyReference()->this_var());
- VisitForAccumulatorValue(
+ VisitForStackValue(
property->obj()->AsSuperPropertyReference()->home_object());
- __ mr(scratch, result_register());
VisitForAccumulatorValue(property->key());
- PushOperands(scratch, result_register());
+ PushOperand(result_register());
if (expr->is_compound()) {
const Register scratch1 = r5;
+ const Register scratch = r4;
__ LoadP(scratch1, MemOperand(sp, 2 * kPointerSize));
- PushOperands(scratch1, scratch, result_register());
+ __ LoadP(scratch2, MemOperand(sp, 1 * kPointerSize));
+ PushOperands(scratch1, scratch2, result_register());
}
break;
}
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698