Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2120963002: [fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a keyed store to a... (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1675 matching lines...) Expand 10 before | Expand all | Expand 10 after
1686 VisitForAccumulatorValue( 1686 VisitForAccumulatorValue(
1687 property->obj()->AsSuperPropertyReference()->home_object()); 1687 property->obj()->AsSuperPropertyReference()->home_object());
1688 PushOperand(result_register()); 1688 PushOperand(result_register());
1689 if (expr->is_compound()) { 1689 if (expr->is_compound()) {
1690 const Register scratch = a1; 1690 const Register scratch = a1;
1691 __ ld(scratch, MemOperand(sp, kPointerSize)); 1691 __ ld(scratch, MemOperand(sp, kPointerSize));
1692 PushOperands(scratch, result_register()); 1692 PushOperands(scratch, result_register());
1693 } 1693 }
1694 break; 1694 break;
1695 case KEYED_SUPER_PROPERTY: { 1695 case KEYED_SUPER_PROPERTY: {
1696 const Register scratch = a1;
1697 VisitForStackValue( 1696 VisitForStackValue(
1698 property->obj()->AsSuperPropertyReference()->this_var()); 1697 property->obj()->AsSuperPropertyReference()->this_var());
1699 VisitForAccumulatorValue( 1698 VisitForStackValue(
1700 property->obj()->AsSuperPropertyReference()->home_object()); 1699 property->obj()->AsSuperPropertyReference()->home_object());
1701 __ Move(scratch, result_register());
1702 VisitForAccumulatorValue(property->key()); 1700 VisitForAccumulatorValue(property->key());
1703 PushOperands(scratch, result_register()); 1701 PushOperand(result_register());
1704 if (expr->is_compound()) { 1702 if (expr->is_compound()) {
1705 const Register scratch1 = a4; 1703 const Register scratch1 = a4;
1704 const Register scratch2 = a1;
1706 __ ld(scratch1, MemOperand(sp, 2 * kPointerSize)); 1705 __ ld(scratch1, MemOperand(sp, 2 * kPointerSize));
1707 PushOperands(scratch1, scratch, result_register()); 1706 __ ld(scratch2, MemOperand(sp, 1 * kPointerSize));
1707 PushOperands(scratch1, scratch2, result_register());
1708 } 1708 }
1709 break; 1709 break;
1710 } 1710 }
1711 case KEYED_PROPERTY: 1711 case KEYED_PROPERTY:
1712 // We need the key and receiver on both the stack and in v0 and a1. 1712 // We need the key and receiver on both the stack and in v0 and a1.
1713 if (expr->is_compound()) { 1713 if (expr->is_compound()) {
1714 VisitForStackValue(property->obj()); 1714 VisitForStackValue(property->obj());
1715 VisitForStackValue(property->key()); 1715 VisitForStackValue(property->key());
1716 __ ld(LoadDescriptor::ReceiverRegister(), 1716 __ ld(LoadDescriptor::ReceiverRegister(),
1717 MemOperand(sp, 1 * kPointerSize)); 1717 MemOperand(sp, 1 * kPointerSize));
(...skipping 2089 matching lines...) Expand 10 before | Expand all | Expand 10 after
3807 reinterpret_cast<uint64_t>( 3807 reinterpret_cast<uint64_t>(
3808 isolate->builtins()->OnStackReplacement()->entry())); 3808 isolate->builtins()->OnStackReplacement()->entry()));
3809 return ON_STACK_REPLACEMENT; 3809 return ON_STACK_REPLACEMENT;
3810 } 3810 }
3811 3811
3812 3812
3813 } // namespace internal 3813 } // namespace internal
3814 } // namespace v8 3814 } // namespace v8
3815 3815
3816 #endif // V8_TARGET_ARCH_MIPS64 3816 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698