Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2120963002: [fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a keyed store to a... (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a keyed store to a super. BUG=chromium:625590 Committed: https://crrev.com/43aee0331d2ff6ce2f6089e879665b648f2fdd15 Cr-Commit-Position: refs/heads/master@{#37497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-625590.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Igor Sheludko
PTAL
4 years, 5 months ago (2016-07-04 11:05:28 UTC) #3
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-04 11:05:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120963002/1
4 years, 5 months ago (2016-07-04 11:11:57 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-04 11:34:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120963002/1
4 years, 5 months ago (2016-07-04 11:39:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 11:41:23 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 11:41:24 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 11:42:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43aee0331d2ff6ce2f6089e879665b648f2fdd15
Cr-Commit-Position: refs/heads/master@{#37497}

Powered by Google App Engine
This is Rietveld 408576698