Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2120943002: Fix evaluation of constant map with duplicate keys. (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix evaluation of constant map with duplicate keys. BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/daed6fa215b41a5c9606b93ce7a7f015a97a61ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-04 13:34:51 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-06 15:51:43 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-08 07:38:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
daed6fa215b41a5c9606b93ce7a7f015a97a61ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698