third_party/WebKit/Source/core/editing/SelectionController.cpp - Issue 2120913002: [Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2120913002: [Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add selection test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all-contenteditable.html ('K') | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/SelectionController.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp

index f29f07d1bc2c743d1ddc37fee0f46193249f96d1..34a3327fc5f6b8630e9295a3d677c564062595dc 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp

@@ -87,6 +87,8 @@ VisibleSelectionInFlatTree expandSelectionToRespectUserSelectAll(Node* targetNod

Node* rootUserSelectAll = EditingInFlatTreeStrategy::rootUserSelectAllForNode(targetNode);

if (!rootUserSelectAll)

return selection;

+ if (rootUserSelectAll->layoutObject()->style()->userModify() != READ_ONLY)

+ return selection;

VisibleSelectionInFlatTree newSelection(selection);

newSelection.setBase(mostBackwardCaretPosition(PositionInFlatTree::beforeNode(rootUserSelectAll), CanCrossEditingBoundary));