[Editing][Regression] Contenteditable w/ "-webkit-user-select:all" should be editable.

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 539 matching lines @@
 {
     if (isPseudoElement())
         return false;
 
     // Ideally we'd call DCHECK(!needsStyleRecalc()) here, but
     // ContainerNode::setFocus() calls setNeedsStyleRecalc(), so the assertion
     // would fire in the middle of Document::setFocusedNode().
 
     for (const Node& node : NodeTraversal::inclusiveAncestorsOf(*this)) {
         if ((node.isHTMLElement() || node.isDocumentNode()) && node.layoutObject()) {
+            const bool isContentEditable = node.isHTMLElement() && toHTMLElement(node).contentEditable() == "true";

[yosin_UTC9, 2016/07/06 07:56:48]

We should not check "contentEditable" attribute. editability is defined by
-webkit-user-modify.

We need to support following case:

<div contentEditable>
  ...
  <span style="user-select: all">this content is editable</span>
  ...
</div>

[yoichio, 2016/07/07 07:57:02]

Done.

             // Elements with user-select: all style are considered atomic
             // therefore non editable.
-            if (nodeIsUserSelectAll(&node) && treatment == UserSelectAllIsAlwaysNonEditable)
+            if (!isContentEditable && nodeIsUserSelectAll(&node) && treatment == UserSelectAllIsAlwaysNonEditable)
                 return false;
             switch (node.layoutObject()->style()->userModify()) {
             case READ_ONLY:
                 return false;
             case READ_WRITE:
                 return true;
             case READ_WRITE_PLAINTEXT_ONLY:
                 return editableLevel != RichlyEditable;
             }
             ASSERT_NOT_REACHED();
@@ skipping 1928 matching lines @@
 
 void showNodePath(const blink::Node* node)
 {
     if (node)
         node->showNodePathForThis();
     else
         fprintf(stderr, "Cannot showNodePath for (nil)\n");
 }
 
 #endif