Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 2120873002: X87: [builtins] New frame type for exits to C++ builtins. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] New frame type for exits to C++ builtins. port 5febc27b5d17f14908d5e3c225bdb9b8a6b2df9a (r37416) original commit message: Prior to this commit, calls to C++ builtins created standard exit frames, which are skipped when constructing JS stack traces. In order to show these calls on traces, we introduce a new builtin exit frame type. Builtin exit frames contain target and new.target on the stack and are not skipped during stack trace construction. BUG= Committed: https://crrev.com/f50725d3baeb12dc8f67e0d9c2c7aac6a38d40d7 Cr-Commit-Position: refs/heads/master@{#37490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 5 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-04 03:24:37 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-04 03:53:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120873002/1
4 years, 5 months ago (2016-07-04 04:05:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/4337) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-04 04:10:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120873002/1
4 years, 5 months ago (2016-07-04 04:11:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 04:27:19 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 04:29:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f50725d3baeb12dc8f67e0d9c2c7aac6a38d40d7
Cr-Commit-Position: refs/heads/master@{#37490}

Powered by Google App Engine
This is Rietveld 408576698