Fix InputImeApiTest.SendKeyEventsOnNormalPage trybot failure.

InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on some special pages. It fails on Site Isolation Linux FYI bot, as the test fails to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test environment. It tests under GURL(kChromeSearchLocalNtpUrl): chrome-search://local-ntp/local-ntp.html, which is special page for input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None

Committed: https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3
Cr-Commit-Position: refs/heads/master@{#403641}

[Azure Wei, 2016-07-04 00:29:50]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 00:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 01:02:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 01:02:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Azure Wei, 2016-07-04 04:15:22]

Description was changed from

==========
SendKey test failure.

BUG=624958
TEST=None
==========

to

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.







BUG=624958
TEST=None
==========

[Azure Wei, 2016-07-04 04:15:38]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 04:15:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Azure Wei, 2016-07-04 04:15:52]

Description was changed from

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.







BUG=624958
TEST=None
==========

to

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None
==========

[commit-bot: I haz the power, 2016-07-04 05:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 05:18:57]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2016-07-04 05:27:23]

azurewei@chromium.org changed reviewers:
+ creis@chromium.org, rdevlin.cronin@chromium.org, shuchen@chromium.org

[Azure Wei, 2016-07-04 05:28:01]

Please review this cl. Thanks!

[Shu Chen, 2016-07-04 06:15:34]

lgtm

[Azure Wei, 2016-07-04 06:26:28]

The CQ bit was checked by azurewei@chromium.org

[commit-bot: I haz the power, 2016-07-04 06:26:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 06:30:43]

Description was changed from

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None
==========

to

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None
==========

[commit-bot: I haz the power, 2016-07-04 06:30:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-04 06:32:35]

Description was changed from

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None
==========

to

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None

Committed: https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3
Cr-Commit-Position: refs/heads/master@{#403641}
==========

[commit-bot: I haz the power, 2016-07-04 06:32:36]

Patchset 4 (id:??) landed as
https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3
Cr-Commit-Position: refs/heads/master@{#403641}

[Devlin, 2016-07-06 16:58:49]

This makes the test pass, but it also doesn't really test in the case of site
isolation (which is a problem).  IIRC, there were a few other tests that had the
problem of newtab appearing as chrome-search - can we add a TODO in the code to
fix this?

[Charlie Reis, 2016-07-06 18:02:26]

Description was changed from

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None

Committed: https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3
Cr-Commit-Position: refs/heads/master@{#403641}
==========

to

==========
InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on
some special pages. It fails on Site Isolation Linux FYI bot, as the test fails
to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test
environment. It tests under GURL(kChromeSearchLocalNtpUrl):
chrome-search://local-ntp/local-ntp.html, which is special page for
input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None

Committed: https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3
Cr-Commit-Position: refs/heads/master@{#403641}
==========

[Charlie Reis, 2016-07-06 18:05:23]

[+site-isolation-reviews]

On 2016/07/06 16:58:49, Devlin wrote:
> This makes the test pass, but it also doesn't really test in the case of site
> isolation (which is a problem).  IIRC, there were a few other tests that had
the
> problem of newtab appearing as chrome-search - can we add a TODO in the code
to
> fix this?

First, thanks for tracking this down to the NTP problem!  I think that's
probably https://crbug.com/456420, which proved difficult to fix at the time.

I think I agree with Devlin that this way of working around it isn't ideal,
though.  This will end up making us forget about this test and we won't ever
have coverage for it in --site-per-process.  Instead, it's better to leave it
disabled and mark the bug as blocked on 456420.  Hopefully the test will pass as
originally written when that bug is fixed.

Can you revert this CL?  I'll take care of the bug triage.  Thanks!

[Azure Wei, 2016-07-07 02:02:36]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2125243002/ by azurewei@chromium.org.

The reason for reverting is: Revert the working around. 
The bug has been marked as blocked on bug:456420..