chrome/common/resource_dispatcher.cc - Issue 21208: POSIX: Transfer network data using shared memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/resource_dispatcher.cc

Issue 21208: POSIX: Transfer network data using shared memory (Closed)

Patch Set: ... Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/resource_dispatcher.cc

diff --git a/chrome/common/resource_dispatcher.cc b/chrome/common/resource_dispatcher.cc

index 7f64d32af4d0263c0eb5d84e572f45c2fa328bf2..e9db613f4a323677d8887f0d690985c6900736b5 100644

--- a/chrome/common/resource_dispatcher.cc

+++ b/chrome/common/resource_dispatcher.cc

@@ -342,7 +342,8 @@ void ResourceDispatcher::OnReceivedData(int request_id,

sender->Send(

new ViewHostMsg_DataReceived_ACK(MSG_ROUTING_NONE, request_id));

- DCHECK((shm_handle && data_len > 0) || (!shm_handle && !data_len));

+ const bool shm_valid = base::SharedMemory::IsHandleValid(shm_handle);

+ DCHECK((shm_valid && data_len > 0) || (!shm_valid && !data_len));

base::SharedMemory shared_mem(shm_handle, true); // read only

PendingRequestList::iterator it = pending_requests_.find(request_id);

« no previous file with comments | « chrome/common/ipc_tests.cc ('k') | chrome/renderer/render_thread.cc » ('j') | no next file with comments »