Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 21208: POSIX: Transfer network data using shared memory (Closed)
Patch Set: ... Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/shared_memory_win.cc ('k') | chrome/chrome.xcodeproj/project.pbxproj » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/browser_render_process_host.cc
diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc
index 24d5f4da7dd7bf944f765813e1881310840dbcc0..eabce0e1c0b1fadd10146272b3ecfaee965924e2 100644
--- a/chrome/browser/renderer_host/browser_render_process_host.cc
+++ b/chrome/browser/renderer_host/browser_render_process_host.cc
@@ -524,18 +524,14 @@ void BrowserRenderProcessHost::InitVisitedLinks() {
return;
}
-#if defined(OS_WIN)
- base::SharedMemoryHandle handle_for_process = NULL;
- visitedlink_master->ShareToProcess(GetRendererProcessHandle(),
- &handle_for_process);
- DCHECK(handle_for_process);
- if (handle_for_process) {
+ base::SharedMemoryHandle handle_for_process;
+ bool r = visitedlink_master->ShareToProcess(GetRendererProcessHandle(),
+ &handle_for_process);
+ DCHECK(r);
+
+ if (base::SharedMemory::IsHandleValid(handle_for_process)) {
channel_->Send(new ViewMsg_VisitedLink_NewTable(handle_for_process));
}
-#else
- // TODO(port): ShareToProcess is Windows-specific.
- NOTIMPLEMENTED();
-#endif
}
void BrowserRenderProcessHost::InitUserScripts() {
@@ -553,11 +549,11 @@ void BrowserRenderProcessHost::InitUserScripts() {
void BrowserRenderProcessHost::SendUserScriptsUpdate(
base::SharedMemory *shared_memory) {
- base::SharedMemoryHandle handle_for_process = NULL;
- shared_memory->ShareToProcess(GetRendererProcessHandle(),
- &handle_for_process);
- DCHECK(handle_for_process);
- if (handle_for_process) {
+ base::SharedMemoryHandle handle_for_process;
+ bool r = shared_memory->ShareToProcess(GetRendererProcessHandle(),
+ &handle_for_process);
+ DCHECK(r);
+ if (base::SharedMemory::IsHandleValid(handle_for_process)) {
channel_->Send(new ViewMsg_UserScripts_NewScripts(handle_for_process));
}
}
« no previous file with comments | « base/shared_memory_win.cc ('k') | chrome/chrome.xcodeproj/project.pbxproj » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698