Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 2120783002: Convert video-controls* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-controls* tests to testharness.js Cleaning up video-controls* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/ade5683989b72668f31606a6f8ba6e321ede1ebd Cr-Commit-Position: refs/heads/master@{#403623}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-03 07:02:19 UTC) #5
fs
lgtm
4 years, 5 months ago (2016-07-03 17:43:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120783002/40001
4 years, 5 months ago (2016-07-03 18:10:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-04 01:14:07 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 01:14:11 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 01:15:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ade5683989b72668f31606a6f8ba6e321ede1ebd
Cr-Commit-Position: refs/heads/master@{#403623}

Powered by Google App Engine
This is Rietveld 408576698