chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc - Issue 2120683002: Fix up certificate error reporting histograms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

Issue 2120683002: Fix up certificate error reporting histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: components/BUILD.gn fix, don't build unit tests on iOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

index bf7027f7bc166382c5f6ec4ffb60ec590291100c..a7f055255773cd666c865ca96686342741e3b059 100644

--- a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

+++ b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

@@ -399,7 +399,7 @@ TEST_F(ChromeExpectCTReporterWaitTest, SendReportFailure) {

histograms.ExpectTotalCount(kFailureHistogramName, 1);

histograms.ExpectBucketCount(kFailureHistogramName,

- net::ERR_CONNECTION_FAILED, 1);

+ -net::ERR_CONNECTION_FAILED, 1);

histograms.ExpectTotalCount(kSendHistogramName, 1);

histograms.ExpectBucketCount(kSendHistogramName, true, 1);

}