chrome/browser/ssl/chrome_expect_ct_reporter.cc - Issue 2120683002: Fix up certificate error reporting histograms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 2120683002: Fix up certificate error reporting histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: components/BUILD.gn fix, don't build unit tests on iOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/chrome_expect_ct_reporter.cc

diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter.cc b/chrome/browser/ssl/chrome_expect_ct_reporter.cc

index 14da6505d7153e123356f4ffbc6aef5c5b9e306e..a8ac0b0636c6a6d23d1121bf8d49c351fed3ca72 100644

--- a/chrome/browser/ssl/chrome_expect_ct_reporter.cc

+++ b/chrome/browser/ssl/chrome_expect_ct_reporter.cc

@@ -105,9 +105,9 @@ void AddValidSCT(const net::SignedCertificateTimestampAndStatus& sct_and_status,

}

// Records an UMA histogram of the net errors when Expect CT reports

-// fails to send.

+// fail to send.

void RecordUMAOnFailure(const GURL& report_uri, int net_error) {

- UMA_HISTOGRAM_SPARSE_SLOWLY("SSL.ExpectCTReportFailure", net_error);

+ UMA_HISTOGRAM_SPARSE_SLOWLY("SSL.ExpectCTReportFailure", -net_error);

}

} // namespace