net/http/transport_security_state_unittest.cc - Issue 2120683002: Fix up certificate error reporting histograms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/transport_security_state_unittest.cc

Issue 2120683002: Fix up certificate error reporting histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/transport_security_state_unittest.cc

diff --git a/net/http/transport_security_state_unittest.cc b/net/http/transport_security_state_unittest.cc

index 62deef2fc56662c7bce4019e94277df89783da6a..1fa689fe0d2c37635ffbbcd10e1b8dff80c96f33 100644

--- a/net/http/transport_security_state_unittest.cc

+++ b/net/http/transport_security_state_unittest.cc

@@ -1387,7 +1387,7 @@ TEST_F(TransportSecurityStateTest, UMAOnHPKPReportingFailure) {

// Check that the UMA histogram was updated when the report failed to

// send.

histograms.ExpectTotalCount(histogram_name, 1);

- histograms.ExpectBucketCount(histogram_name, mock_report_sender.net_error(),

+ histograms.ExpectBucketCount(histogram_name, -mock_report_sender.net_error(),

1);

}