Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 2120683002: Fix up certificate error reporting histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_expect_ct_reporter.cc
diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter.cc b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
index 14da6505d7153e123356f4ffbc6aef5c5b9e306e..a8ac0b0636c6a6d23d1121bf8d49c351fed3ca72 100644
--- a/chrome/browser/ssl/chrome_expect_ct_reporter.cc
+++ b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
@@ -105,9 +105,9 @@ void AddValidSCT(const net::SignedCertificateTimestampAndStatus& sct_and_status,
}
// Records an UMA histogram of the net errors when Expect CT reports
-// fails to send.
+// fail to send.
void RecordUMAOnFailure(const GURL& report_uri, int net_error) {
- UMA_HISTOGRAM_SPARSE_SLOWLY("SSL.ExpectCTReportFailure", net_error);
+ UMA_HISTOGRAM_SPARSE_SLOWLY("SSL.ExpectCTReportFailure", -net_error);
felt 2016/07/01 22:05:58 Will this change the histogram? Do you need to def
estark 2016/07/01 22:08:53 It will change it, but I think it's okay. I'm pret
felt 2016/07/01 22:13:48 If you're the only one looking at it, probably fin
}
} // namespace
« no previous file with comments | « no previous file | chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc » ('j') | components/certificate_reporting/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698