Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 2120673003: Fix the script used to roll GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the script used to roll GN. This updates the script to handle the latest inconsistencies in the buildbot step logging, and also removes the CQ_EXTRA_TRYBOTS logic for the old builders. R=brettw@chromium.org Committed: https://crrev.com/061d24c115ac682e388c25fbccdd012fbb7c1a63 Cr-Commit-Position: refs/heads/master@{#403693}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M tools/gn/bin/roll_gn.py View 2 chunks +12 lines, -5 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-03 18:04:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120673003/1
4 years, 5 months ago (2016-07-03 20:30:13 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-03 21:14:07 UTC) #5
brettw
lgtm https://codereview.chromium.org/2120673003/diff/1/tools/gn/bin/roll_gn.py File tools/gn/bin/roll_gn.py (right): https://codereview.chromium.org/2120673003/diff/1/tools/gn/bin/roll_gn.py#newcode278 tools/gn/bin/roll_gn.py:278: # restarted we can probably assert that the ...
4 years, 5 months ago (2016-07-03 23:26:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120673003/1
4 years, 5 months ago (2016-07-04 16:41:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 16:44:55 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 16:44:58 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 16:47:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/061d24c115ac682e388c25fbccdd012fbb7c1a63
Cr-Commit-Position: refs/heads/master@{#403693}

Powered by Google App Engine
This is Rietveld 408576698