Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2120673002: Clean up the browser_tests filter for Site Isolation bots. (Closed)

Created:
4 years, 5 months ago by alexmos
Modified:
4 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up the browser_tests filter for Site Isolation bots. Previously, the filter disabled 192 tests. However, lots of these tests were actually passing with --site-per-process, mostly due to unnecessarily wide wildcards. This CL explicitly lists all the actual failures, and also removes a couple of WebRtc tests which seem to be passing now. This brings the number of disabled tests down to 26. BUG=417518, 603261 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/b1320e8f04eb906f295def43d4cf4894d7bc5b7a Cr-Commit-Position: refs/heads/master@{#403928}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M testing/buildbot/filters/site-per-process.browser_tests.filter View 2 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
alexmos
Charlie, can you please take a look? I ran the try bot three times to ...
4 years, 5 months ago (2016-07-01 23:05:55 UTC) #2
Charlie Reis
This is great! I'm glad we're down to a manageable number of failures. LGTM. Do ...
4 years, 5 months ago (2016-07-01 23:24:34 UTC) #3
alexmos
Thanks! On 2016/07/01 23:24:34, Charlie Reis wrote: > This is great! I'm glad we're down ...
4 years, 5 months ago (2016-07-01 23:28:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120673002/20001
4 years, 5 months ago (2016-07-06 16:34:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/31528) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-06 16:35:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120673002/40001
4 years, 5 months ago (2016-07-06 16:47:05 UTC) #12
commit-bot: I haz the power
Transient error: Invalid delimiter in "linux_site_isolation": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
4 years, 5 months ago (2016-07-06 16:47:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120673002/40001
4 years, 5 months ago (2016-07-06 16:48:55 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 17:38:30 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 17:38:35 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 17:41:28 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b1320e8f04eb906f295def43d4cf4894d7bc5b7a
Cr-Commit-Position: refs/heads/master@{#403928}

Powered by Google App Engine
This is Rietveld 408576698