|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by alexmos Modified:
4 years, 5 months ago Reviewers:
Charlie Reis CC:
chromium-reviews, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean up the browser_tests filter for Site Isolation bots.
Previously, the filter disabled 192 tests. However, lots of these
tests were actually passing with --site-per-process, mostly due to
unnecessarily wide wildcards. This CL explicitly lists all the actual
failures, and also removes a couple of WebRtc tests which seem to be
passing now. This brings the number of disabled tests down to 26.
BUG=417518, 603261
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/b1320e8f04eb906f295def43d4cf4894d7bc5b7a
Cr-Commit-Position: refs/heads/master@{#403928}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Messages
Total messages: 21 (10 generated)
alexmos@chromium.org changed reviewers: + creis@chromium.org
Charlie, can you please take a look? I ran the try bot three times to make sure there are no flakes. Something must have fixed the WebRtc tests, since they all work now. Tabs2 might be fixed too, as it's passing for me locally, but I'll leave it in for now, since we have a bug filed for it being flaky specifically on the bots.
This is great! I'm glad we're down to a manageable number of failures. LGTM. Do you want to land this now or after the long weekend, when we can react if one of the tests fails?
Thanks! On 2016/07/01 23:24:34, Charlie Reis wrote: > This is great! I'm glad we're down to a manageable number of failures. LGTM. > > Do you want to land this now or after the long weekend, when we can react if one > of the tests fails? Good point - I'll wait until after the long weekend.
The CQ bit was checked by alexmos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)
Description was changed from ========== Clean up the browser_tests filter for Site Isolation bots. Previously, the filter disabled 192 tests. However, lots of these tests were actually passing with --site-per-process, mostly due to unnecessarily wide wildcards. This CL explicitly lists all the actual failures, and also removes a couple of WebRtc tests which seem to be passing now. This brings the number of disabled tests down to 26. BUG=417518, 603261 ========== to ========== Clean up the browser_tests filter for Site Isolation bots. Previously, the filter disabled 192 tests. However, lots of these tests were actually passing with --site-per-process, mostly due to unnecessarily wide wildcards. This CL explicitly lists all the actual failures, and also removes a couple of WebRtc tests which seem to be passing now. This brings the number of disabled tests down to 26. BUG=417518, 603261 CQ_INCLUDE_TRYBOTS=linux_site_isolation ==========
The CQ bit was checked by alexmos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org Link to the patchset: https://codereview.chromium.org/2120673002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Transient error: Invalid delimiter in "linux_site_isolation": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
Description was changed from ========== Clean up the browser_tests filter for Site Isolation bots. Previously, the filter disabled 192 tests. However, lots of these tests were actually passing with --site-per-process, mostly due to unnecessarily wide wildcards. This CL explicitly lists all the actual failures, and also removes a couple of WebRtc tests which seem to be passing now. This brings the number of disabled tests down to 26. BUG=417518, 603261 CQ_INCLUDE_TRYBOTS=linux_site_isolation ========== to ========== Clean up the browser_tests filter for Site Isolation bots. Previously, the filter disabled 192 tests. However, lots of these tests were actually passing with --site-per-process, mostly due to unnecessarily wide wildcards. This CL explicitly lists all the actual failures, and also removes a couple of WebRtc tests which seem to be passing now. This brings the number of disabled tests down to 26. BUG=417518, 603261 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by alexmos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Clean up the browser_tests filter for Site Isolation bots. Previously, the filter disabled 192 tests. However, lots of these tests were actually passing with --site-per-process, mostly due to unnecessarily wide wildcards. This CL explicitly lists all the actual failures, and also removes a couple of WebRtc tests which seem to be passing now. This brings the number of disabled tests down to 26. BUG=417518, 603261 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Clean up the browser_tests filter for Site Isolation bots. Previously, the filter disabled 192 tests. However, lots of these tests were actually passing with --site-per-process, mostly due to unnecessarily wide wildcards. This CL explicitly lists all the actual failures, and also removes a couple of WebRtc tests which seem to be passing now. This brings the number of disabled tests down to 26. BUG=417518, 603261 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/b1320e8f04eb906f295def43d4cf4894d7bc5b7a Cr-Commit-Position: refs/heads/master@{#403928} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b1320e8f04eb906f295def43d4cf4894d7bc5b7a Cr-Commit-Position: refs/heads/master@{#403928} |
