Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2120603002: DevTools: gray out linenumbers for the unmapped source code lines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: disallow setting breakpoint on lines without sourcemapping Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1111 }, 1111 },
1112 1112
1113 /** 1113 /**
1114 * @param {number} lineNumber 1114 * @param {number} lineNumber
1115 * @param {number} columnNumber 1115 * @param {number} columnNumber
1116 * @param {string} condition 1116 * @param {string} condition
1117 * @param {boolean} enabled 1117 * @param {boolean} enabled
1118 */ 1118 */
1119 _setBreakpoint: function(lineNumber, columnNumber, condition, enabled) 1119 _setBreakpoint: function(lineNumber, columnNumber, condition, enabled)
1120 { 1120 {
1121 if (!WebInspector.debuggerWorkspaceBinding.uiLineHasMapping(this.uiSourc eCode(), lineNumber))
1122 return;
1123
1121 this._breakpointManager.setBreakpoint(this.uiSourceCode(), lineNumber, c olumnNumber, condition, enabled); 1124 this._breakpointManager.setBreakpoint(this.uiSourceCode(), lineNumber, c olumnNumber, condition, enabled);
1122 }, 1125 },
1123 1126
1124 dispose: function() 1127 dispose: function()
1125 { 1128 {
1126 this._breakpointManager.removeEventListener(WebInspector.BreakpointManag er.Events.BreakpointAdded, this._breakpointAdded, this); 1129 this._breakpointManager.removeEventListener(WebInspector.BreakpointManag er.Events.BreakpointAdded, this._breakpointAdded, this);
1127 this._breakpointManager.removeEventListener(WebInspector.BreakpointManag er.Events.BreakpointRemoved, this._breakpointRemoved, this); 1130 this._breakpointManager.removeEventListener(WebInspector.BreakpointManag er.Events.BreakpointRemoved, this._breakpointRemoved, this);
1128 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .SourceMappingChanged, this._onSourceMappingChanged, this); 1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .SourceMappingChanged, this._onSourceMappingChanged, this);
1129 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this); 1132 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this);
1130 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this); 1133 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this);
1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this); 1134 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this);
1132 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this); 1135 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this);
1133 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this); 1136 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this);
1134 WebInspector.UISourceCodeFrame.prototype.dispose.call(this); 1137 WebInspector.UISourceCodeFrame.prototype.dispose.call(this);
1135 }, 1138 },
1136 1139
1137 __proto__: WebInspector.UISourceCodeFrame.prototype 1140 __proto__: WebInspector.UISourceCodeFrame.prototype
1138 } 1141 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698