Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2120603002:
DevTools: gray out linenumbers for the unmapped source code lines (Closed)
|
Created:
4 years, 5 months ago by lushnikov Modified:
4 years, 5 months ago Reviewers:
paulirish CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: gray out linenumbers for the unmapped source code lines
This patch:
- grays out linenumbers for the unmapped source code lines
- disabled setting breakpoint on these lines
These are cosmetic changes - currently, breakpoints will
never break if set on the line without mapping.
BUG=479733
R=paulirish
Committed: https://crrev.com/4b7aa6e5c053b5afa4023390a4f0aead2d4b2d3e
Cr-Commit-Position: refs/heads/master@{#403950}
Patch Set 1 #Patch Set 2 : disallow setting breakpoint on lines without sourcemapping #
Messages
Total messages: 26 (15 generated)
Screenshot: http://i.imgur.com/eeJy5hC.png Please, take a look!
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by paulirish@chromium.org
please, take a look
The CQ bit was checked by lushnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from paulirish@chromium.org Link to the patchset: https://codereview.chromium.org/2120603002/#ps20001 (title: "disallow setting breakpoint on lines without sourcemapping")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lushnikov@chromium.org
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
The CQ bit was unchecked by lushnikov@chromium.org
Description was changed from ========== DevTools: gray out linenumbers for the unmapped source code lines BUG=479733 R=paulirish ========== to ========== DevTools: gray out linenumbers for the unmapped source code lines This patch: - grays out linenumbers for the unmapped source code lines - disabled setting breakpoint on these lines These are cosmetic changes - currently, breakpoints will never break if set on the line without mapping. BUG=479733 R=paulirish ==========
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: gray out linenumbers for the unmapped source code lines This patch: - grays out linenumbers for the unmapped source code lines - disabled setting breakpoint on these lines These are cosmetic changes - currently, breakpoints will never break if set on the line without mapping. BUG=479733 R=paulirish ========== to ========== DevTools: gray out linenumbers for the unmapped source code lines This patch: - grays out linenumbers for the unmapped source code lines - disabled setting breakpoint on these lines These are cosmetic changes - currently, breakpoints will never break if set on the line without mapping. BUG=479733 R=paulirish ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== DevTools: gray out linenumbers for the unmapped source code lines This patch: - grays out linenumbers for the unmapped source code lines - disabled setting breakpoint on these lines These are cosmetic changes - currently, breakpoints will never break if set on the line without mapping. BUG=479733 R=paulirish ========== to ========== DevTools: gray out linenumbers for the unmapped source code lines This patch: - grays out linenumbers for the unmapped source code lines - disabled setting breakpoint on these lines These are cosmetic changes - currently, breakpoints will never break if set on the line without mapping. BUG=479733 R=paulirish Committed: https://crrev.com/4b7aa6e5c053b5afa4023390a4f0aead2d4b2d3e Cr-Commit-Position: refs/heads/master@{#403950} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4b7aa6e5c053b5afa4023390a4f0aead2d4b2d3e Cr-Commit-Position: refs/heads/master@{#403950} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
