Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2120543003:
fixed non-GPU build (Closed)
|
Created:
4 years, 5 months ago by ethannicholas Modified:
4 years, 5 months ago Reviewers:
dogben CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionfixed non-GPU build
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120543003
NOTREECHECKS=true
Committed: https://skia.googlesource.com/skia/+/b442f6834c1b60e9b17c09a642b0a552474f463e
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== fixed non-GPU build ========== to ========== fixed non-GPU build GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120543003 ==========
ethannicholas@google.com changed reviewers: + benjaminwagner@google.com
lgtm
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== fixed non-GPU build GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120543003 ========== to ========== fixed non-GPU build GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120543003 NOTREECHECKS=true ==========
The CQ bit was unchecked by benjaminwagner@google.com
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== fixed non-GPU build GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120543003 NOTREECHECKS=true ========== to ========== fixed non-GPU build GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120543003 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/b442f6834c1b60e9b17c09a642b0a552474f463e ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b442f6834c1b60e9b17c09a642b0a552474f463e |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
