Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2120533002: SkPDF: Fix encoding of unichr outside of basic plane (Closed)

Created:
4 years, 5 months ago by hal.canary
Modified:
4 years, 5 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Fix encoding of unichr outside of basic plane In ToUnicode table, write unicode codepoints as one or two UTF16BE values, rather than a single hex, as the standard requires. Factor out uint16 -> big-endian hex code. SkUtils is now a namespace. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120533002 Committed: https://skia.googlesource.com/skia/+/a76a10b730ae3fb2abb7c06839ca9c5d14df5ca7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -47 lines) Patch
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 3 chunks +15 lines, -5 lines 0 comments Download
M src/pdf/SkPDFUtils.h View 2 chunks +46 lines, -35 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120533002/1
4 years, 5 months ago (2016-07-01 16:33:06 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/9426)
4 years, 5 months ago (2016-07-01 16:39:56 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120533002/1
4 years, 5 months ago (2016-07-01 17:05:58 UTC) #7
hal.canary
PTAL
4 years, 5 months ago (2016-07-01 17:06:00 UTC) #9
hal.canary
See section 9.10.3 of PDF32000-1:2008
4 years, 5 months ago (2016-07-01 17:07:45 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 17:09:28 UTC) #12
tomhudson
lgtm
4 years, 5 months ago (2016-07-07 18:55:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120533002/1
4 years, 5 months ago (2016-07-07 19:07:37 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:31:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a76a10b730ae3fb2abb7c06839ca9c5d14df5ca7

Powered by Google App Engine
This is Rietveld 408576698