Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2120493002: Remove dtlsidentitystore.h from libjingle GYP/GN files. (Closed)

Created:
4 years, 5 months ago by hbos_chromium
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dtlsidentitystore.h from libjingle GYP/GN files. This file contains an interface that is about to be removed (https://codereview.webrtc.org/2034013003) since it is no longer used by chromium (https://codereview.chromium.org/2033353002). The build files have to be updated before the file is removed from the webrtc repo or else the webrtc roll will cause chromium to break. BUG=webrtc:5708, webrtc:5707 NOTRY=true Committed: https://crrev.com/cf80340266d7b7e0bd3098e00df2bdf47145f2a2 Cr-Commit-Position: refs/heads/master@{#404614}

Patch Set 1 #

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120493002/1
4 years, 5 months ago (2016-07-01 15:20:26 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 5 months ago (2016-07-01 15:43:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 16:45:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120493002/1
4 years, 5 months ago (2016-07-02 20:21:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/249574)
4 years, 5 months ago (2016-07-02 21:19:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120493002/20001
4 years, 5 months ago (2016-07-11 08:08:27 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 08:12:35 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 08:12:48 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:15:53 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf80340266d7b7e0bd3098e00df2bdf47145f2a2
Cr-Commit-Position: refs/heads/master@{#404614}

Powered by Google App Engine
This is Rietveld 408576698