Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2120473004: Reimplement devfs in dart. Implementation now writes to disk. (Closed)

Created:
4 years, 5 months ago by turnidge
Modified:
3 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reimplement devfs in dart. Implementation now writes to disk. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f7242f21373f994be697c4052afed6c1b0d24a82

Patch Set 1 #

Patch Set 2 : Cleanups pre review #

Total comments: 2

Patch Set 3 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -607 lines) Patch
M runtime/bin/vmservice/vmservice_io.dart View 1 2 2 chunks +44 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_test.dart View 6 chunks +26 lines, -22 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/vm/dev_fs.h View 1 chunk +0 lines, -55 lines 0 comments Download
D runtime/vm/dev_fs.cc View 1 chunk +0 lines, -375 lines 0 comments Download
M runtime/vm/service.cc View 3 chunks +0 lines, -136 lines 0 comments Download
M runtime/vm/service_isolate.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A sdk/lib/vmservice/devfs.dart View 1 chunk +319 lines, -0 lines 0 comments Download
M sdk/lib/vmservice/vmservice.dart View 1 10 chunks +58 lines, -8 lines 0 comments Download
M sdk/lib/vmservice/vmservice_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
turnidge
4 years, 5 months ago (2016-07-01 20:45:01 UTC) #2
Cutch
LGTM with some nits and a suggestion https://codereview.chromium.org/2120473004/diff/20001/runtime/bin/vmservice/vmservice_io.dart File runtime/bin/vmservice/vmservice_io.dart (right): https://codereview.chromium.org/2120473004/diff/20001/runtime/bin/vmservice/vmservice_io.dart#newcode94 runtime/bin/vmservice/vmservice_io.dart:94: map['size'] = ...
4 years, 5 months ago (2016-07-01 21:23:17 UTC) #3
turnidge
4 years, 5 months ago (2016-07-01 21:57:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f7242f21373f994be697c4052afed6c1b0d24a82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698