Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2120473002: Web Audio: measure cross origin iframe usage. (Closed)

Created:
4 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 5 months ago
Reviewers:
Ilya Sherman, dcheng
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, haraken, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Audio: measure cross origin iframe usage. In order to figure out whether we can add restrictions on Web Audio usage on cross origin iframes without breaking the Web. BUG=625136 Committed: https://crrev.com/ab151b40b44688092a5c0a8b5e0d26d963020dec Cr-Commit-Position: refs/heads/master@{#403669}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
mlamouri (slow - plz ping)
dcheng@, PTAL :)
4 years, 5 months ago (2016-07-01 13:03:45 UTC) #2
mlamouri (slow - plz ping)
+isherman@, PTAL at histograms changes.
4 years, 5 months ago (2016-07-01 13:04:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120473002/1
4 years, 5 months ago (2016-07-01 13:04:26 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/30074) ios-device-gn on ...
4 years, 5 months ago (2016-07-01 13:06:07 UTC) #8
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-07-01 16:39:37 UTC) #9
dcheng
rs lgtm
4 years, 5 months ago (2016-07-04 06:48:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120473002/20001
4 years, 5 months ago (2016-07-04 09:50:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-04 12:11:55 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 12:12:08 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 12:13:30 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab151b40b44688092a5c0a8b5e0d26d963020dec
Cr-Commit-Position: refs/heads/master@{#403669}

Powered by Google App Engine
This is Rietveld 408576698