Issue 2120383002: Update test and status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2120383002: Update test and status file. (Closed)

Created:
4 years, 5 months ago by floitsch

Modified:
4 years, 5 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update test and status file. Committed: https://github.com/dart-lang/sdk/commit/951bb7750bcd5cc3305e99ed294fd50a719dac97

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tests/language/arg_param_trailing_comma_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/language/language.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

I hope this fixes it. We should probably find a bug for this and update ...

4 years, 5 months ago (2016-07-04 21:11:55 UTC) #2

floitsch

Committed patchset #1 (id:1) manually as 951bb7750bcd5cc3305e99ed294fd50a719dac97 (presubmit successful).

4 years, 5 months ago (2016-07-04 21:12:07 UTC) #4

Lasse Reichstein Nielsen

4 years, 5 months ago (2016-07-05 06:15:44 UTC) #5

Message was sent while issue was closed.

LGTM.
I think the problem is in the wrapper script which tries to detect how many
parameters main takes, and gets confused by `main(args, )` and passes two
arguments.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages