copy graphics state fully

copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

Premultiply bits retrieved from images, and check
to see that the device bits are always
premultiplied.

Look for null graphics state and matrices.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
Committed: https://pdfium.googlesource.com/pdfium/+/a27d49a3e9eafd7fd911a0a6039ce80284ccb463

[caryclark, 2016-07-05 17:12:30]

Description was changed from

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
==========

to

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
==========

[caryclark, 2016-07-05 17:12:49]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 17:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 17:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 17:45:18]

Dry run: Try jobs failed on following builders:
  win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/b...)

[caryclark, 2016-07-05 19:44:35]

Description was changed from

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
==========

to

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

Premultiply bits on device if called by
image renderer.

Look for null graphics state and matrices.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
==========

[caryclark, 2016-07-05 19:44:43]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 19:44:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 20:04:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 20:04:36]

Dry run: Try jobs failed on following builders:
  win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/b...)

[caryclark, 2016-07-06 16:14:01]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 16:14:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-07-06 16:17:56]

Description was changed from

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

Premultiply bits on device if called by
image renderer.

Look for null graphics state and matrices.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
==========

to

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

Premultiply bits retrieved from images, and check
to see that the device bits are always
premultiplied.

Look for null graphics state and matrices.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
==========

[caryclark, 2016-07-06 16:32:07]

Even though the last checkin is labeled 'wip: ...', please go ahead and review
this. It completes run_corpus_tests.py without any hard crashes / asserts in
Debug.

[commit-bot: I haz the power, 2016-07-06 16:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 16:40:10]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-07-06 17:20:06]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-06 17:20:07]

lgtm

[commit-bot: I haz the power, 2016-07-06 17:20:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 17:20:29]

Description was changed from

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

Premultiply bits retrieved from images, and check
to see that the device bits are always
premultiplied.

Look for null graphics state and matrices.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532
==========

to

==========
copy graphics state fully

The dash parameters where not copied; the copy
could point at random data and cause corpus
tests to hang when testing Skia.

PDFium measures text directly by calling FreeType.
Turn off hinting altogether in Skia so that drawn
text matches the metrics that PDFium measures.

Premultiply bits retrieved from images, and check
to see that the device bits are always
premultiplied.

Look for null graphics state and matrices.

R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:532

Committed:
https://pdfium.googlesource.com/pdfium/+/a27d49a3e9eafd7fd911a0a6039ce80284cc...
==========

[commit-bot: I haz the power, 2016-07-06 17:20:30]

Committed patchset #9 (id:160001) as
https://pdfium.googlesource.com/pdfium/+/a27d49a3e9eafd7fd911a0a6039ce80284cc...

[commit-bot: I haz the power, 2016-07-06 17:20:32]

CQ bit was unchecked.