gpu/command_buffer/service/framebuffer_manager.cc - Issue 2120343002: command_buffer: correctly use glGetFramebufferAttachmentParameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 2120343002: command_buffer: correctly use glGetFramebufferAttachmentParameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/framebuffer_manager.cc

diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc

index 04f05f6c89a02e14a3c148937a7cfe8c48f19c59..0c5d96708e856d8e9c3d8578eb785c9f2d18c71e 100644

--- a/gpu/command_buffer/service/framebuffer_manager.cc

+++ b/gpu/command_buffer/service/framebuffer_manager.cc

@@ -552,6 +552,10 @@ void Framebuffer::MarkAttachmentsAsCleared(

}

+bool Framebuffer::HasColorAttachment(int index) const {

+ return attachments_.find(GL_COLOR_ATTACHMENT0 + index) != attachments_.end();

bool Framebuffer::HasDepthAttachment() const {

return attachments_.find(GL_DEPTH_STENCIL_ATTACHMENT) != attachments_.end() ||

attachments_.find(GL_DEPTH_ATTACHMENT) != attachments_.end();