command_buffer: correctly use glGetFramebufferAttachmentParameter

command_buffer: correctly use glGetFramebufferAttachmentParameter

It is used instead of some glGet on a core OpenGL profile and the Intel
Mesa driveri (correctly) produces and error when the attachment queried
doesn't exist.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/aafbfa02af91e1b2f9f49b0ae2333b6f2c3517e1
Cr-Commit-Position: refs/heads/master@{#403924}

[Corentin Wallez, 2016-07-04 19:55:00]

Description was changed from

==========
command_buffer: correctly use glGetFramebufferAttachmentParameter

It is used instead of some glGet on a core OpenGL profile and the Intel
Mesa driveri (correctly) produces and error when the attachment queried
doesn't exist.

BUG=598902
==========

to

==========
command_buffer: correctly use glGetFramebufferAttachmentParameter

It is used instead of some glGet on a core OpenGL profile and the Intel
Mesa driveri (correctly) produces and error when the attachment queried
doesn't exist.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-07-04 19:57:48]

cwallez@chromium.org changed reviewers:
+ zmo@chromium.org

[Corentin Wallez, 2016-07-04 19:57:48]

PTAL, thanks!

[Zhenyao Mo, 2016-07-04 23:16:06]

https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6070: if
(framebuffer->HasColorAttachment(0)) {
Here we have a pre-existing issue: we should query any attachment since they all
have the same format.  Here we limit to COLOR_ATTACHMENT0, but we don't have to
have an image attached to COLOR_ATTACHMENT0.

https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6092: if (framebuffer &&
framebuffer->HasDepthAttachment()) {
This should be an inter if statement.  Because if framebuffer is not null, and
you don't have depth attachment, you should return 0 (already set by default)
rather than querying the back_buffer.

https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6114: if (framebuffer &&
framebuffer->HasColorAttachment(0)) {
Here we should do similar things as GL_ALPHA_BITS, checking color formats are
the same, checking at least one color attachment exists, and put this condition
as an inner loop.

https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6145: if (framebuffer &&
framebuffer->HasStencilAttachment()) {
Same here, should be an inner if statement.

[Corentin Wallez, 2016-07-05 18:53:23]

On 2016/07/04 at 23:16:06, zmo wrote:
>
https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:6070: if
(framebuffer->HasColorAttachment(0)) {
> Here we have a pre-existing issue: we should query any attachment since they
all have the same format.  Here we limit to COLOR_ATTACHMENT0, but we don't have
to have an image attached to COLOR_ATTACHMENT0.
> 
>
https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:6092: if (framebuffer &&
framebuffer->HasDepthAttachment()) {
> This should be an inter if statement.  Because if framebuffer is not null, and
you don't have depth attachment, you should return 0 (already set by default)
rather than querying the back_buffer.
> 
>
https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:6114: if (framebuffer &&
framebuffer->HasColorAttachment(0)) {
> Here we should do similar things as GL_ALPHA_BITS, checking color formats are
the same, checking at least one color attachment exists, and put this condition
as an inner loop.
> 
>
https://codereview.chromium.org/2120343002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:6145: if (framebuffer &&
framebuffer->HasStencilAttachment()) {
> Same here, should be an inner if statement.

PTAL again, addressed comments.

[Zhenyao Mo, 2016-07-05 21:14:16]

lgtm with one left over fixed.

https://codereview.chromium.org/2120343002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2120343002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6095: if (framebuffer &&
framebuffer->HasDepthAttachment()) {
Remove it here? Since you moved it inside.

[Corentin Wallez, 2016-07-06 13:55:42]

On 2016/07/05 at 21:14:16, zmo wrote:
> lgtm with one left over fixed.
> 
>
https://codereview.chromium.org/2120343002/diff/20001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2120343002/diff/20001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:6095: if (framebuffer &&
framebuffer->HasDepthAttachment()) {
> Remove it here? Since you moved it inside.

Thanks for the review, CQ time.

[Corentin Wallez, 2016-07-06 13:55:44]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-07-06 13:55:45]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2120343002/#ps40001
(title: "Address last comment?")

[commit-bot: I haz the power, 2016-07-06 13:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 15:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 15:41:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Corentin Wallez, 2016-07-06 16:40:20]

On 2016/07/06 at 15:41:35, commit-bot wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Failures look unrelated, trying again.

[Corentin Wallez, 2016-07-06 16:40:22]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-07-06 16:40:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 17:14:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-06 17:14:39]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 17:16:43]

Description was changed from

==========
command_buffer: correctly use glGetFramebufferAttachmentParameter

It is used instead of some glGet on a core OpenGL profile and the Intel
Mesa driveri (correctly) produces and error when the attachment queried
doesn't exist.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command_buffer: correctly use glGetFramebufferAttachmentParameter

It is used instead of some glGet on a core OpenGL profile and the Intel
Mesa driveri (correctly) produces and error when the attachment queried
doesn't exist.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/aafbfa02af91e1b2f9f49b0ae2333b6f2c3517e1
Cr-Commit-Position: refs/heads/master@{#403924}
==========

[commit-bot: I haz the power, 2016-07-06 17:16:44]

Patchset 3 (id:??) landed as
https://crrev.com/aafbfa02af91e1b2f9f49b0ae2333b6f2c3517e1
Cr-Commit-Position: refs/heads/master@{#403924}