Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2120303002: Make toolbar color opaque in browser theme (Closed)

Created:
4 years, 5 months ago by sunxd
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Make toolbar color opaque in browser theme In the bug, the ui assumes using lcd_text by default, but the theme has transparent toolbar_color, rendering subpixel makes the text seem weird. This CL forces the color to be opaque (alpha value = 0xff). It worked before because the can_use_lcd_text property of status bubble is set before we compute layer draw properties, and the property is disabled all the time. But now we compute layer draw properties on demand, the can_use_lcd_text property becomes true as the whole layer tree is set to be able to use lcd text. BUG=618278 Review-Url: https://codereview.chromium.org/2044223006 Cr-Commit-Position: refs/heads/master@{#403593} (cherry picked from commit 32c538f0e6cd40ebd53f336f1f3fae7eb404070b) Committed: https://chromium.googlesource.com/chromium/src/+/4ee6dcc8331fe45ae305c79bda5320a96a92f204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sunxd
4 years, 5 months ago (2016-07-04 14:56:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ee6dcc8331fe45ae305c79bda5320a96a92f204.

Powered by Google App Engine
This is Rietveld 408576698