Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 21203005: Enable runtime checks for SSSE3 on x86 on Android. (Closed)

Created:
7 years, 4 months ago by mtklein
Modified:
7 years, 4 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Enable runtime checks for SSSE3 on x86 on Android. $ compare-android.sh bench --match bitmap_ --repeat 30 master -> ssse3 N=30 p=0.001000 (corrected to 0.000033) sig? speedup bench n -1.16% bitmap_scale_filter_256_64 y -0.72% bitmap_8888_A_scale_bicubic y -0.21% bitmap_index8_A n -0.00% bitmap_565 n -0.00% bitmap_scale_filter_90_80 n 0.03% bitmap_8888_A_source_transparent y 0.06% bitmap_index8 y 0.30% bitmap_8888_A_source_stripes_two n 0.34% bitmap_scale_filter_80_90 y 0.42% bitmap_8888_A y 0.44% bitmap_8888_A_source_opaque n 0.53% bitmap_scale_filter_90_10 y 0.71% bitmap_8888_A_source_stripes_three y 0.91% bitmap_8888_A_scale_rotate_bicubic y 1.04% bitmap_8888_update n 1.19% bitmap_scale_filter_10_90 n 1.39% bitmap_scale_filter_90_90 y 1.77% bitmap_8888_update_volatile y 1.89% bitmap_8888 y 2.37% bitmap_scale_filter_30_90 y 9.57% bitmap_scale_filter_64_256 n 17.86% bitmap_scale_filter_90_30 y 25.40% bitmap_8888_A_scale_rotate_bilerp y 27.19% bitmap_8888_scale_rotate_bilerp y 27.23% bitmap_8888_update_scale_rotate_bilerp y 27.29% bitmap_8888_update_volatile_scale_rotate_bilerp y 55.08% bitmap_8888_A_scale_bilerp y 58.75% bitmap_8888_update_volatile_scale_bilerp y 58.90% bitmap_8888_scale_bilerp y 58.92% bitmap_8888_update_scale_bilerp Overall speedup: 10.52% BUG=skia:1111 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M gyp/opts.gyp View 2 chunks +5 lines, -7 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
So far so good. Testing on razr i trybot too.
7 years, 4 months ago (2013-07-30 18:52:34 UTC) #1
djsollen
lgtm
7 years, 4 months ago (2013-07-31 12:33:42 UTC) #2
mtklein
7 years, 4 months ago (2013-07-31 20:09:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r10474 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698