Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2120283003: NTP, modify the snippet header display to above the peeking card (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index cb24ef20feba9367d55bd9b3edfb9a8c07ea30bd..cb60db70713415b2311dda7a3a95b44de7c1db7c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -397,7 +397,6 @@ public class NewTabPageView extends FrameLayout
}
});
initializeSearchBoxRecyclerViewScrollHandling();
- mRecyclerView.updateSnippetsHeaderDisplay(mNewTabPageLayout.getPaddingTop());
} else {
initializeSearchBoxScrollHandling();
}
@@ -483,7 +482,7 @@ public class NewTabPageView extends FrameLayout
}
updateSearchBoxOnScroll();
mRecyclerView.updatePeekingCard();
- mRecyclerView.updateSnippetsHeaderDisplay(mNewTabPageLayout.getPaddingTop());
+ mRecyclerView.updateSnippetsHeaderDisplay();
}
});
@@ -819,6 +818,7 @@ public class NewTabPageView extends FrameLayout
if (mUseCardsUi) {
mRecyclerView.updatePeekingCard();
+ mRecyclerView.updateSnippetsHeaderDisplay();
// The positioning of elements may have been changed (since the elements expand to fill
// the available vertical space), so adjust the scroll.
mRecyclerView.snapScroll(mSearchBoxView, getVerticalScroll(), getHeight());
@@ -1087,6 +1087,7 @@ public class NewTabPageView extends FrameLayout
if (mUseCardsUi) {
mRecyclerView.updatePeekingCard();
+ mRecyclerView.updateSnippetsHeaderDisplay();
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698