[turbofan] Better handling of empty type in simplified lowering.

[turbofan] Better handling of empty type in simplified lowering.

The re-typer now only types a node if its inputs are all typed with the
exception of phi nodes. This works because all cycles in the graph have
to contain a phi node.

BUG=chromium:625558
Committed: https://crrev.com/9fdacb9e554e2b1ba235d9bb8e7f5cd8ee653883
Cr-Commit-Position: refs/heads/master@{#37493}

[Jarin, 2016-07-04 07:33:05]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Jarin, 2016-07-04 07:33:05]

Could you take a look, please?

[Benedikt Meurer, 2016-07-04 07:41:46]

LGTM with comments.

https://codereview.chromium.org/2120243002/diff/1/src/compiler/operation-type...
File src/compiler/operation-typer.cc (right):

https://codereview.chromium.org/2120243002/diff/1/src/compiler/operation-type...
src/compiler/operation-typer.cc:293: return Type::None();
Please use TypeBinaryOp as in the typer.cc.

[Jarin, 2016-07-04 08:40:10]

https://codereview.chromium.org/2120243002/diff/1/src/compiler/operation-type...
File src/compiler/operation-typer.cc (right):

https://codereview.chromium.org/2120243002/diff/1/src/compiler/operation-type...
src/compiler/operation-typer.cc:293: return Type::None();
On 2016/07/04 07:41:45, Benedikt Meurer wrote:
> Please use TypeBinaryOp as in the typer.cc.

I am not a big fan of the TypeBinaryOp machinery (because of the method pointer
+ passing the typer around). Let us first land this and then decide what to do
about the repeated code.

[Jarin, 2016-07-04 08:40:21]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-07-04 08:40:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2120243002/#ps20001
(title: "Disable slow test")

[commit-bot: I haz the power, 2016-07-04 08:40:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 08:42:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-04 08:43:21]

Description was changed from

==========
[turbofan] Better handling of empty type in simplified lowering.

The re-typer now only types a node if its inputs are all typed with the
exception of phi nodes. This works because all cycles in the graph have
to contain a phi node.

BUG=chromium:625558
==========

to

==========
[turbofan] Better handling of empty type in simplified lowering.

The re-typer now only types a node if its inputs are all typed with the
exception of phi nodes. This works because all cycles in the graph have
to contain a phi node.

BUG=chromium:625558

Committed: https://crrev.com/9fdacb9e554e2b1ba235d9bb8e7f5cd8ee653883
Cr-Commit-Position: refs/heads/master@{#37493}
==========

[commit-bot: I haz the power, 2016-07-04 08:43:21]

Patchset 2 (id:??) landed as
https://crrev.com/9fdacb9e554e2b1ba235d9bb8e7f5cd8ee653883
Cr-Commit-Position: refs/heads/master@{#37493}